Use Modified Preorder Tree Traversal in Category

product/models.py patch for MPTT

sorry, changing to enhancement

I've attached a diff with some changes that were necessary to get it to run. However, I'm seeing regressions in the tests. Would you verify that the tests pass and update them as needed?

left and right are keywords in SQL, so you can't use them for field names, hence the lft and rght. Maybe there should be a comment in there explaining that.

I'll take a look at changes besides those and see how to run these tests.

Harry

Okay I've updated the changes again. I noticed some errors in my initial version. It would only allow for one root in all the categories, but the demo store has 3 separate root categories: Books, Shirts, Software. So I've updated the class to allow for multiple roots. The data is correct in the admin for the demo store. It wasn't in the first iteration.

Included comments about the purposely misspelled left and right: lft, rght

Also noticed that the test cases assume that you will be able to create an infinite loop with the Category class. The class with this patch won't let you make an infinite loop because it will immediately reorder the tree on save. The subsequent tests fail because they need the infinite loop to be in the database.

I can add some more tests to tests.py that just give more straightforward category structures and makes sure the data comes back correct. My thoughts were to add multiple root categories like in the demo store, make sure the parents are correct, the children come back correct. I've spent one day with the class so I was hoping to work with someone to ensure I'm testing for the right data.

r3 11/02/07 05:09:25 changes

Do we also need to look at modifying the satchmo_category.py template tag to not recurse?

I'm looking at updating that now.

I found this project which has some code that might be useful - http://code.google.com/p/django-categories/

Another implementation - http://code.google.com/p/django-mptt/

I'm moving out of the next release. This might be useful but it's not a requirement at this time.

thanks get a cool air force ones

http://www.salewroughtiron.cn installing metal stair rails Interior stair handrail installing metal stair rails Interior stair handrail exterior baluster Glass wood stainless wrought CONTEMPORARY designs stairways aluminum modern log banister DECK outdoor price posts vinyl curved rails http://www.china-made-door.com.cn door gate http://www.beijing-door.cn wrought CONTEMPORARY designs stairways installing metal stair rails Interior stair handrail exterior baluster Glass wood stainless wrought CONTEMPORARY designs stairways aluminum modern log banister DECK outdoor price posts vinyl curved rails http://www.hebei-railings.cn aluminum modern log banister DECK outdoor price installing metal stair rails Interior stair handrail exterior baluster Glass wood stainless wrought CONTEMPORARY designs stairways aluminum modern log banister DECK outdoor price posts vinyl curved rails posts vinyl curved rails

china tour Apparel shoes bags Kitchen Food and Wine Furniture) Flowers and Gifts Wall Art Computer Components

I still prefer a wiki like approach since the php (or mysql) docs are very cluttered when you have to take their comments in account. On the other hand they are professionally maintained imho, since they are *much* better than KDE documentation. KDE is by far larger and has so many different apps, which need screenshots and end user not dev/api docs, that more help is needed as long as the devs prefer to code than to write nice docs. And it is their choice to some degree imo. Technically interested but non-dev end users, which are plenty out there, are the users of and the best contributers to the docs, since they know what to write about. And they are certainly more than devs